linux-kernel - Re: [BUG] soc/sti: a possible sleep-in-atomic bug in uni_player_ctl_iec958

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26c49bcf-65d9-f7d7-d281-a1cb0f978ebb@st.com>
Date:   Tue, 12 Dec 2017 17:11:56 +0100
From:   Arnaud Pouliquen <arnaud.pouliquen@...com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <perex@...ex.cz>, <tiwai@...e.com>,
        <dan.carpenter@...cle.com>
CC:     <alsa-devel@...a-project.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] soc/sti: a possible sleep-in-atomic bug in
 uni_player_ctl_iec958_put

Hello Jia-Ju,


On 12/12/2017 03:27 PM, Jia-Ju Bai wrote:
> According to sound/soc/sti/uniperif_player.c, the driver may sleep under
> a spinlock.
> The function call path is:
> uni_player_ctl_iec958_put (acquire the spinlock)
>   uni_player_set_channel_status
>     mutex_lock --> may sleep
> 
> I do not find a good way to fix it, so I only report.
> This possible bug is found by my static analysis tool (DSAC) and checked
> by my code review.
you right, mutex under spin lock is not recommended... I will have a look
Thanks!

Regards
Arnaud

> 
> 
> Thanks,
> Jia-Ju Bai