linux-kernel - Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 18:05:25 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-iio@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc
 driver.

On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote:
> On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote:
> > +   Alessandro Zummo
> > +   Alexandre Belloni
> > 
> > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra
> > <enric.balletbo@...labora.com>:
> > > Dear all,
> > >
> > > This is an attempt to revive some patches from that [1] patchset, some
> > > of them are still under discussion but I think there is no reason to not
> > > have the other two in this fourth version to land upstream meanwhile we
> > > discuss about the others.
> > >
> > > [1] https://lkml.org/lkml/2017/7/12/182
> > >
> > > Changes since v3:
> > > * Rebased an retested with current mainline using a Samsung Chromebook Plus
> > > * Removed from patchset
> > >   * 1/4 mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.
> > >   * 4/4 mfd: cros_ec: add RTC as mfd subdevice.
> > >
> > > Changes since v2:
> > > - Rebase on top of mainline.
> > > - Removed patch 'mfd: cros-ec: Fix host command buffer size' from series
> > > as was already picked.
> > >
> > > Changes since v1:
> > > - Removed patch 'iio: cros_ec_sensors: Fix return value to get raw and
> > > calibbias data' from series as was already picked.
> > > - Removed patch 'iio: cros_ec_sensors: Fix return value to get raw and
> > > calibbias data' from series as was already picked.
> > > - Patch 2/5: Acked-by: Jonathan Cameron <***@...nel.org>
> > >
> > > Best regards,
> > >
> > >  Enric
> > >
> > > Stephen Barber (2):
> > >   mfd: cros_ec: Introduce RTC commands and events definitions.
> > >   rtc: cros-ec: add cros-ec-rtc driver.
> > >
> > >  drivers/rtc/Kconfig                  |  10 +
> > >  drivers/rtc/Makefile                 |   1 +
> > >  drivers/rtc/rtc-cros-ec.c            | 413 +++++++++++++++++++++++++++++++++++
> > >  include/linux/mfd/cros_ec_commands.h |   8 +
> > >  4 files changed, 432 insertions(+)
> > >  create mode 100644 drivers/rtc/rtc-cros-ec.c
> > >
> > > --
> > > 2.9.3
> > >
> > 
> > Sorry, I just noticed that my script to add the email recipients
> > failed and I did not add the RTC maintainers :( So this is a gentle
> > ping cc'ing the maintainers to take in consideration these patches. If
> > you want I resend or something else just let me know please.
> > 
> 
> I don't remember the specifics but I think the patches have the
> necessary acks from me to go through the mfd tree (didn't we agree on
> that ?)
> 

This was the reply from Lee a while ago:

> On Wed, 18 Jan 2017, Alexandre Belloni wrote:
> > I don't think that one has your ack, is it ok for me to take it?
> 
> This set looks MFD heavy, so it's probably best that the set goes
> through MFD.  Once the RTC patch has been fixed of course.

The series doesn't look MFD heavy anymore so it can also go through my
tree. I'll let Lee decide.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com