linux-kernel - Re: [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d092d9e0-2c28-f5d2-26d6-6c57029309d5@gmail.com>
Date:   Wed, 13 Dec 2017 09:13:59 -0700
From:   David Ahern <dsahern@...il.com>
To:     Roman Gushchin <guro@...com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-team@...com, ast@...nel.org,
        daniel@...earbox.net, jakub.kicinski@...ronome.com, kafai@...com,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations

On 12/13/17 8:18 AM, Roman Gushchin wrote:
> This patch adds basic cgroup bpf operations to bpftool:
> cgroup list, attach and detach commands.
> 
> Usage is described in the corresponding man pages,
> and examples are provided.
> 
> Syntax:
> $ bpftool cgroup list CGROUP
> $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS]
> $ bpftool cgroup detach CGROUP ATTACH_TYPE PROG
> 
> Signed-off-by: Roman Gushchin <guro@...com>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Cc: Martin KaFai Lau <kafai@...com>
> Cc: Quentin Monnet <quentin.monnet@...ronome.com>
> Reviewed-by: David Ahern <dsahern@...il.com>
> ---

The updates for attach flags and man page look great. Very user
friendly. Thanks for the work on it.