linux-kernel - Re: [tip:x86/urgent] x86/mm/kmmio: Fix mmiotrace for page unaligned addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171213113135.1a8af60d@gandalf.local.home>
Date:   Wed, 13 Dec 2017 11:31:35 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ilia Mirkin <imirkin@...m.mit.edu>, Ingo Molnar <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Pekka Paalanen <ppaalanen@...il.com>, Lyude <lyude@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Karol Herbst <kherbst@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>, hpa@...or.com,
        linux-tip-commits@...r.kernel.org,
        Karol Herbst <karolherbst@...il.com>
Subject: Re: [tip:x86/urgent] x86/mm/kmmio: Fix mmiotrace for page unaligned
 addresses

On Tue, 12 Dec 2017 15:51:05 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> On Tue, Dec 12, 2017 at 09:47:05AM -0500, Ilia Mirkin wrote:
> > > So this 'thing' has huge gaping SMP holes in.  
> > 
> > Sure does! Probably why the following happens when mmiotrace is enabled:
> > 
> > void enable_mmiotrace(void)
> > {
> >         mutex_lock(&mmiotrace_mutex);
> >         if (is_enabled())
> >                 goto out;
> > 
> >         if (nommiotrace)
> >                 pr_info("MMIO tracing disabled.\n");
> >         kmmio_init();
> >         enter_uniprocessor();  
> 
> 	^^^^^
> 
> Ah! I completely missed that. OK, that makes it much less broken :-)

/me just saw this thread.

Once I saw your initial complaint, my first thought was "I think he
doesn't know that it causes the system to turn into a uniprocessor
first".

My ftrace tests have a test that switches to each tracer, and this
mmiotrace catches the most bugs after an rc1 release. The bugs are
triggered by switching to and from uniprocessor mode. Hopefully, with
the new hotplug code, that will be a thing of the past.

> 
> If I don't forget, I'll add some comments to this file to clarify that.

Great, thanks!

-- Steve

>