linux-kernel - Re: [BUG] drivers/gpio: some possible sleep-in-atomic bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5A3152C4.4070802@gaisler.com>
Date:   Wed, 13 Dec 2017 17:18:12 +0100
From:   Andreas Larsson <andreas@...sler.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>, linus.walleij@...aro.org
CC:     linux-gpio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] drivers/gpio: some possible sleep-in-atomic bugs

On 2017-12-12 04:59, Jia-Ju Bai wrote:
> According to drivers/gpio/gpio-grgpio.c, the kernel module may sleep
> under a spinlock.
> The function call paths are:
> grgpio_remove (acquire the spinlock)
>    gpiochip_remove
>      gpiochip_sysfs_unregister
>        device_unregister --> may sleep
>        mutex_lock --> may sleep
>
> grgpio_remove (acquire the spinlock)
>    gpiochip_remove
>      gpiochip_sysfs_unregister
>        gpiod_free
>          __gpiod_free
>            gpiod_unexport
>              device_unregister --> may sleep
>              mutex_lock --> may sleep
>
> grgpio_remove (acquire the spinlock)
>    irq_domain_remove
>      mutex_lock --> may sleep
>
> grgpio_irq_map (acquire the spinlock)
>    request_irq --> may sleep
>
> grgpio_irq_unmap (acquire the spinlock)
>    free_irq --> may sleep
>
>
> I do not find a good way to fix them, so I only report.
> These possible bugs is found by my static analysis tool (DSAC) and
> checked by my code review.
Hi!

Thank you for reporting this. I will take a look at it.

-- 
Best Regards,
Andreas Larsson