linux-kernel - Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171213173633.57edca85@vento.lan>
Date:   Wed, 13 Dec 2017 17:36:33 -0200
From:   Mauro Carvalho Chehab <mchehab@...pensource.com>
To:     <Yasunari.Takiguchi@...y.com>
Cc:     <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <tbird20d@...il.com>, <frowand.list@...il.com>,
        <Masayuki.Yamamoto@...y.com>, <Hideki.Nozawa@...y.com>,
        <Kota.Yonezawa@...y.com>, <Toshihiko.Matsumoto@...y.com>,
        <Satoshi.C.Watanabe@...y.com>, "Bird, Timothy" <Tim.Bird@...y.com>
Subject: Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and
 driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Em Fri, 13 Oct 2017 14:46:35 +0900
<Yasunari.Takiguchi@...y.com> escreveu:

> From: Yasunari Takiguchi <Yasunari.Takiguchi@...y.com>
> 
> Hi,
> 
> This is the patch series (version 4) of Sony CXD2880 DVB-T2/T tuner + 
> demodulator driver.The driver supports DVB-API and interfaces through 
> SPI.
> 
> We have tested the driver on Raspberry Pi 3 and got picture and sound 
> from a media player.
> 
> The change history of this patch series is as below.

Finally had time to review this patch series. Sorry for taking so long.
4Q is usually very busy.

I answered each patch with comments. There ones I didn't comment
(patches 1, 4 and 8-12) is because I didn't see anything wrong,
except for the notes I did on other patches, mainly:
	- they lack SPDX license text;
	- the error codes need to review.

Additionally, on patches 8-11, I found weird to not found any
64 bits division, but I noticed some code there that it seemed
to actually be doing such division using some algorithm to make
them work on 32 bits machine. If so, please replace them by
do_div64(), as it makes clearer about what's been doing, and it
provides better performance when compiled on 64 bit Kernels (as
they become just a DIV asm operation).

Regards,
Mauro

Thanks,
Mauro