linux-kernel - Applied "spi: jcore: disable clock when registering spi conroller failed" to the spi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1ePCvr-0002SE-Js@debutante>
Date:   Wed, 13 Dec 2017 19:43:07 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Takuo Koguchi <takuo.koguchi@...il.com>
Cc:     Takuo Koguchi <takuo.koguchi.sw@...achi.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        khoroshilov@...ras.ru, takuo.koguchi@...il.com,
        takuo.koguchi.sw@...achi.com, Mark Brown <broonie@...nel.org>,
        linux-spi@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Applied "spi: jcore: disable clock when registering spi conroller failed" to the spi tree

The patch

   spi: jcore: disable clock when registering spi conroller failed

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 16eab16ef9382704ff12c68ef52d62c68219cbb9 Mon Sep 17 00:00:00 2001
From: Takuo Koguchi <takuo.koguchi@...il.com>
Date: Thu, 7 Dec 2017 19:11:41 +0900
Subject: [PATCH] spi: jcore: disable clock when registering spi conroller
 failed

 When probe function fails in registering the spi controller, the clock
 should remain disabled.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@...achi.com>
Signed-off-by: Mark Brown <broonie@...nel.org>
---
 drivers/spi/spi-jcore.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-jcore.c b/drivers/spi/spi-jcore.c
index cebfea5faa4b..dafed6280df3 100644
--- a/drivers/spi/spi-jcore.c
+++ b/drivers/spi/spi-jcore.c
@@ -198,8 +198,10 @@ static int jcore_spi_probe(struct platform_device *pdev)

 	/* Register our spi controller */
 	err = devm_spi_register_master(&pdev->dev, master);
-	if (err)
+	if (err) {
+		clk_disable(clk);
 		goto exit;
+	}

 	return 0;

-- 
2.15.1