linux-kernel - Re: [PATCH] mtd: nand: fix memory leak on ep on error exit returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b246f50c-df86-738a-f192-98c6f4ee449b@canonical.com>
Date:   Wed, 13 Dec 2017 21:09:10 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd@...ts.infradead.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: nand: fix memory leak on ep on error exit returns

On 13/12/17 21:02, Boris Brezillon wrote:
> Hi Colin,
> 
> On Wed, 13 Dec 2017 20:49:09 +0000
> Colin King <colin.king@...onical.com> wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> There are two error return paths that are not kfree'ing ep that
>> lead to memory leaks.  Fix this by exiting on error via the
>> ext_out exit path that performs the necessary kfree.
> 
> Well, given that no one implements the ->exec_op() hook yet, the
> xxxx_op() functions always return 0 right now, but I agree, we
> should fix the generic case. 
> 
>>
>> Detected by CoverityScan, CID#1462747 ("Resource Leak")
>>
>> Fixes: b83ea87958c5 ("mtd: nand: provide several helpers to do common NAND operations")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> If you don't mind, I'd like to squash these changes in the original
> commit.

Yep, no problem with squashing it.

Colin
> 
> Thanks,
> 
> Boris
> 
>> ---
>>  drivers/mtd/nand/nand_base.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
>> index eb810d5d44e7..1c5126d1db8c 100644
>> --- a/drivers/mtd/nand/nand_base.c
>> +++ b/drivers/mtd/nand/nand_base.c
>> @@ -5046,14 +5046,14 @@ static int nand_flash_detect_ext_param_page(struct nand_chip *chip,
>>  	/* Send our own NAND_CMD_PARAM. */
>>  	ret = nand_read_param_page_op(chip, 0, NULL, 0);
>>  	if (ret)
>> -		return ret;
>> +		goto ext_out;
>>  
>>  	/* Use the Change Read Column command to skip the ONFI param pages. */
>>  	ret = nand_change_read_column_op(chip,
>>  					 sizeof(*p) * p->num_of_param_pages,
>>  					 ep, len, true);
>>  	if (ret)
>> -		return ret;
>> +		goto ext_out;
>>  
>>  	ret = -EINVAL;
>>  	if ((onfi_crc16(ONFI_CRC_BASE, ((uint8_t *)ep) + 2, len - 2)
>