linux-kernel - Re: [PATCH v2 03/11] ASoC: fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 14:36:24 -0800
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:     broonie@...nel.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
        lgirdwood@...il.com, fabio.estevam@....com, timur@...i.org,
        caleb@...me.org, arnaud.mouiche@...oxia.com, lukma@...x.de,
        kernel@...gutronix.de
Subject: Re: [PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments

On Wed, Dec 13, 2017 at 11:28:51PM +0100, Maciej S. Szmigiero wrote:

> > -	/*
> > -	 * If we're in synchronous mode, and the SSI is already enabled,
> > -	 * then STCCR is already set properly.
> > -	 */
> > +	/* To support simultaneous TX and RX, bypass it if SSI is enabled */
> >  	if (enabled && ssi->cpu_dai_drv.symmetric_rates)
> >  		return 0;
> >  
> 
> I would say that the old comment described better what is happening -
> since in synchronous (& non-AC'97) mode STCCR controls both TX and RX
> the first direction that is started (either playback or capture) is the
> only direction that needs to configure SSI in hw_params().

There is also an SCR register configuration in this hw_params(),
so the old comment has to be updated. But I would take it into
consideration and revise a bit.

Thanks.