linux-kernel - Re: [PATCH] ACPI, APEI, Fix use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h5AMJkQFm3uHX+DS=tSeYgYq+6=h0b-WP8Y+McSTLc3w@mail.gmail.com>
Date:   Thu, 14 Dec 2017 00:07:30 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Vasyl Gomonovych <gomonovych@...il.com>,
        Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI, APEI, Fix use resource_size

On Wed, Dec 13, 2017 at 4:38 PM, Borislav Petkov <bp@...en8.de> wrote:
> On Wed, Dec 13, 2017 at 01:19:55AM +0100, Rafael J. Wysocki wrote:
>> On Monday, December 11, 2017 4:44:31 PM CET Vasyl Gomonovych wrote:
>> > Use resource_size function on resource object
>> > Underneath __request_region set res->end to start + n - 1
>> > Lets use resourse_size to set value properly.
>> >
>> > Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
>>
>> Boris, what do you think?
>
> So if MAINTAINERS says we review apei stuff, it doesn't mean that you
> should completely stop doing that! :-P

Which is exactly why you've got this question at all. ;-)

> So this looks like a fix to me since it didn't do the + 1 before.
>
> I don't believe this would break any APEI stuff but it should be tested
> a little just in case.

OK, let's queue it up for 4.16, then.