linux-kernel - Re: [PATCH 0/8] make some functions return bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 23:16:41 -0500
From:   Yaowei Bai <baiyaowei@...s.chinamobile.com>
To:     David Rientjes <rientjes@...gle.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] make some functions return bool

On Tue, Dec 12, 2017 at 07:47:09PM -0800, David Rientjes wrote:
> On Tue, 12 Dec 2017, Randy Dunlap wrote:
> 
> > Sure, but I didn't keep the patch emails.
> > 
> > Acked-by: Randy Dunlap <rdunlap@...radead.org>
> > 
> 
> You may have noticed changing functions like is_file_lru() to bool when it 
> is used to index into an array or as part of an arithmetic operation for 

Yes, you're right. is_file_lru should not return bool. I'm using some
automitic ways to detect this type of functions. Pls ignore that patch
or i'll resend patchset without that one later. Thanks.

> ZVC stats.  I'm not sure why you would ack such code.