linux-kernel - Re: [PATCH] powercap: Remove reassignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1535899.2uxoW1GXQ1@aspire.rjw.lan>
Date:   Wed, 13 Dec 2017 02:03:14 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] powercap: Remove reassignment

On Saturday, November 11, 2017 6:47:26 PM CET Arvind Yadav wrote:
> It is not necessary to reassignment of 'result'.
> Here, result is being initialized zero and then updated with
> seed_constraint_attributes().
> class_register is enough to return successful and error value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/powercap/powercap_sys.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> index 5b10b50..64b2b25 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -673,15 +673,13 @@ EXPORT_SYMBOL_GPL(powercap_unregister_control_type);
>  
>  static int __init powercap_init(void)
>  {
> -	int result = 0;
> +	int result;
>  
>  	result = seed_constraint_attributes();
>  	if (result)
>  		return result;
>  
> -	result = class_register(&powercap_class);
> -
> -	return result;
> +	return class_register(&powercap_class);
>  }
>  
>  device_initcall(powercap_init);
> 

Applied, thanks!