linux-kernel - Re: [PATCH] KVM: introduce kvm_arch_vcpu_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171213094755.428f8f26.cohuck@redhat.com>
Date:   Wed, 13 Dec 2017 09:47:55 +0100
From:   Cornelia Huck <cohuck@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        kvm-ppc@...r.kernel.org, christoffer.dall@...aro.org,
        James Hogan <jhogan@...nel.org>,
        Paul Mackerras <paulus@...abs.org>,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH] KVM: introduce kvm_arch_vcpu_async_ioctl

On Tue, 12 Dec 2017 18:31:55 +0100
Paolo Bonzini <pbonzini@...hat.com> wrote:

> After the vcpu_load/vcpu_put pushdown, the handling of asynchronous VCPU
> ioctl is already much clearer in that it is obvious that they bypass
> vcpu_load and vcpu_put.
> 
> However, it is still not perfect in that the different state of the VCPU
> mutex is still hidden in the caller.  Separate those ioctls into a new
> function kvm_arch_vcpu_async_ioctl that returns -ENOIOCTLCMD for more
> "traditional" synchronous ioctls.
> 
> Cc: James Hogan <jhogan@...nel.org>
> Cc: Paul Mackerras <paulus@...abs.org>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Suggested-by: Cornelia Huck <cohuck@...hat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  arch/mips/kvm/mips.c       | 15 ++++++++++++---
>  arch/powerpc/kvm/powerpc.c | 14 +++++++++++---
>  arch/s390/kvm/kvm-s390.c   | 16 ++++++++++++----
>  include/linux/kvm_host.h   |  2 ++
>  virt/kvm/kvm_main.c        |  8 ++++----
>  5 files changed, 41 insertions(+), 14 deletions(-)

Another vote for a dummy function here, but otherwise

Reviewed-by: Cornelia Huck <cohuck@...hat.com>