linux-kernel - [BUG] kaweth: a possible sleep-in-atomic bug in kaweth_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <384f1b94-1fd1-cd38-f8ab-fcba872c77e9@gmail.com>
Date:   Wed, 13 Dec 2017 16:57:18 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     David Miller <davem@...emloft.net>, tklauser@...tanz.ch,
        johannes.berg@...el.com, arvind.yadav.cs@...il.com,
        edumazet@...gle.com
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [BUG] kaweth: a possible sleep-in-atomic bug in kaweth_start_xmit

According to drivers/net/usb/kaweth.c, the driver may sleep under a 
spinlock.
The function call path is:
kaweth_start_xmit (acquire the spinlock)
   kaweth_async_set_rx_mode
     kaweth_control
       kaweth_internal_control_msg
         usb_start_wait_urb
           wait_event_timeout --> may sleep
           usb_kill_urb --> may sleep

I do not find a good way to fix it, so I only report.
This possible bug is found by my static analysis tool (DSAC) and checked 
by my code review.


Thanks,
Jia-Ju Bai