linux-kernel - Re: [PATCH] spi: s3c64xx: add SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 09:38:06 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Andi Shyti <andi@...zian.org>, Kukjin Kim <kgene@...nel.org>,
        linux-spi@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier

On Wed, Dec 13, 2017 at 10:48:54AM +0900, Andi Shyti wrote:

> > > +//
> > > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
> > > +//      Jaswinder Singh <jassi.brar@...sung.com>

> it just looks ugly to me to have something like

>   // SPDX...

>   /*
>    * Copyright (c)...
>    *      Jasw...
>    */

> I would make everything of the '//' style (I've also seen that
> this is the trend also in other subsystems), but honestly I don't
> really care. If you're strong on not moving entirely in '//' style

Yes, my preference is to avoid a mixture like you've got there.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)