linux-kernel - Re: [PATCH] spi: s3c64xx: add SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20171213014854.GG20051@gangnam.samsung>
Date:   Wed, 13 Dec 2017 10:48:54 +0900
From:   Andi Shyti <andi.shyti@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Philippe Ombredanne <pombredanne@...b.com>,
        Andi Shyti <andi@...zian.org>, Kukjin Kim <kgene@...nel.org>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier

Hi Krzysztof,

> > Here, this should be as a top line:
> >
> > // SPDX-License-Identifier: GPL-2.0+
> >
> >
> > So I agree with the SPDX id but also pointing to the use of the C++ //
> > comment style as requested by Linus [1]
> 
> Thanks for the reference. I see that Linus prefers converting entire
> comment into // style. I was not arguing about SPDX line but entire
> existing copyright comment which follows it:
> 
> > +//
> > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
> > +//      Jaswinder Singh <jassi.brar@...sung.com>

it just looks ugly to me to have something like

  // SPDX...
  
  /*
   * Copyright (c)...
   *      Jasw...
   */

I would make everything of the '//' style (I've also seen that
this is the trend also in other subsystems), but honestly I don't
really care. If you're strong on not moving entirely in '//' style
then I can resend it with the double comment style.

Andi

P.S. About GPLv2 vs GPLv2+ I checked and I will repost it keeping
the license as its original. Thanks!