linux-kernel - Re: [PATCH 1/1] staging: rtl8723bs: make memcmp() calls consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 12:47:28 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Hans de Goede <hdegoede@...hat.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: rtl8723bs: make memcmp() calls consistent

On Sun, Dec 10, 2017 at 08:35:12PM +0100, Nicolas Iooss wrote:
> rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when
> parsing extra, and then parses extra+4 as an int:
> 
>     if (!memcmp(extra, "lps =", 4)) {
>         sscanf(extra+4, "%u", &mode);
>     /* ... */
>     } else if (!memcmp(extra, "ips =", 4)) {
>         sscanf(extra+4, "%u", &mode);
> 
> The space between the key ("lps" and "ips") and the equal sign seems
> suspicious. Remove it in order to make the calls to memcmp() consistent.

But you now just changing the parsing logic.  What broke because of
this?  Did you test this codepath with your patch?

I'm not disagreeing that this code seems really odd, but it must be
working as-is for someone, to change this logic will break their system
:(

thanks,

greg k-h