linux-kernel - Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513167907.27409.3.camel@perches.com>
Date:   Wed, 13 Dec 2017 04:25:07 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dhaval Shah <dhaval.shah@...tnautics.com>,
        Philippe Ombredanne <pombredanne@...b.com>
Cc:     "pali.rohar@...il.com" <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
 subsequent lines

On Wed, 2017-12-13 at 10:53 +0000, Dhaval Shah wrote:
> > > This is different issue. If we need to fix the issue of this if we update SPDX licensing as well.
> > > I am agree with you on the use of the new SPDX IDs instead of the long legalese.
> > > For this, we have to add the text "// SPDX-License-Identifier: GPL-2.0" at the top of the file and remove the
> > > whole license part and keep on copyright and Author name related info. After change, it looks like
> > > // SPDX-License-Identifier: GPL-2.0
> > > /*
> > >   *  Dell Airplane Mode Switch driver
> > >   *  Copyright (C) 2014-2015  Pali Rohár <pali.rohar@...il.com>
> > >   */
> > 
> > And for a short comment block like this, Linus preference is to avoid
> > mixing comment style and go all the way C++ style as in:
> > 
> > > // SPDX-License-Identifier: GPL-2.0
> > > // Dell Airplane Mode Switch driver
> > > // Copyright (C) 2014-2015  Pali Rohár <pali.rohar@...il.com>
> > > 
> > > ... for even less boilerplate ;)
> 
> Thanks a lot for the link.
> Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this patch merge?

If anyone does conversions of these license texts
you have to be _extremely_ careful about what
specific license identifier you use.

This license includes the text
	"or (at your option) any later version"
which is not the same as using
	SPDX-License-Identifier: GPL-2.0