linux-kernel - Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171213153027.7aaab62b@zaytsev.tver.pg>
Date:   Wed, 13 Dec 2017 15:30:27 +0300
From:   Mikhail Zaytsev <flashed@...l.ru>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case
 from ioctl

On Wed, 13 Dec 2017 12:40:48 +0100 Oliver Neukum <oneukum@...e.com> wrote:

> They give you nothing. If you are looking at a vendor ID nothing but the
> bare number makes sense. You are just making peoples' life harder when
> they have to look up that definition. A symbolic name is fine if it gives
> meaning. Even if the information you give is that the value is magic
> and therefore not understood. But a vendor ID is an arbitrary yet
> meaningful number. There is no point in hiding it.

Thanks. I hear you, Oliver. What about:

-		serstruct.baud_base = 460800;

Is it a magic number? I think yes.

-- 
Mikhail