linux-kernel - Re: [PATCH] perf tools: Fix swap for samples with raw data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 13:36:34 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, David Ahern <dsahern@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] perf tools: Fix swap for samples with raw data

On Wed, Dec 13, 2017 at 09:33:58AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 29, 2017 at 07:43:46PM +0100, Jiri Olsa escreveu:
> > The fix is basically to swap back the raw data if different
> > endianity is detected.
>  
> > +++ b/tools/perf/util/evsel.c
> > @@ -36,6 +36,7 @@
> >  #include "trace-event.h"
> >  #include "stat.h"
> > +#include "memswap.h"
> 
> > @@ -2131,14 +2132,27 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
> >  	if (type & PERF_SAMPLE_RAW) {
> 
> > +		if (swapped)
> > +			mem_bswap_64((void *) array, data->raw_size);
> > +
> 
> 
> you forgot to add util/memswap.c to tools/perf/util/python-ext-sources,
> breaking 'perf test python'.
> 
> Please run 'perf test' before sending pull requests :-)
> 

ouch ;-)

> Fixed it this time.

thanks,
jirka