linux-kernel - Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 13:08:37 +0000
From:   Dhaval Shah <dhaval.shah@...tnautics.com>
To:     Philippe Ombredanne <pombredanne@...b.com>
CC:     "pali.rohar@...il.com" <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
 subsequent lines


Hi Philippe,



________________________________________
> From: Philippe Ombredanne <pombredanne@...b.com>
> Sent: Wednesday, December 13, 2017 6:27 PM
> To: Dhaval Shah
> Cc: pali.rohar@...il.com; Darren Hart; Andy Shevchenko; platform-driver-x86@...r.kernel.org; LKML
> Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines
> 
> Dhaval,
> 
> On Wed, Dec 13, 2017 at 11:47 AM, Dhaval Shah
> <dhaval.shah@...tnautics.com> wrote:
> 
> <snip>
> > > And for a short comment block like this, Linus preference is to avoid
> > > mixing comment style and go all the way C++ style as in:
> > >
> > > > // SPDX-License-Identifier: GPL-2.0
> > > > // Dell Airplane Mode Switch driver
> > > > // Copyright (C) 2014-2015  Pali Rohár <pali.rohar@...il.com>
> > > >
> > > > ... for even less boilerplate ;)
> >
> > Thanks a lot for the link.
> > Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this patch merge?
> 
> That's not for me to decide, I am just a lowly licensing elf helper scruffy!
I can assume that current patch is accepted or I have to provide you any changes

> PS: you might want to avoid sending HTML email on lkml, FWIW.
That is done by mistake. sorry for that. I will take care of that.

--
Cordially
Philippe Ombredanne