linux-kernel - Re: [PATCH PTI v3 03/10] x86/pti/64: Fix ESPFIX64 user mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171213131205.adxjdggby7qpv22q@node.shutemov.name>
Date:   Wed, 13 Dec 2017 16:12:05 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Borislav Petkov <bp@...en8.de>,
        Brian Gerst <brgerst@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH PTI v3 03/10] x86/pti/64: Fix ESPFIX64 user mapping

On Tue, Dec 12, 2017 at 07:56:38AM -0800, Andy Lutomirski wrote:
> The ESPFIX64 user mapping belongs in pti.c just like all the other
> user mappings.  Move it there and make it work correctly while we're
> at it.
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

BTW, why do we open-code p?d_alloc() in pti_user_pagetable_walk_*()?
It seems unnecessary and potentially bogus: see smp_wmb() in __p?d_alloc()
helpers.

-- 
 Kirill A. Shutemov