linux-kernel - Re: [PATCH v8 4/4] KVM: X86: Add flush_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <445145f5-8f4d-09db-a4cd-32c5b2e331e7@redhat.com>
Date:   Wed, 13 Dec 2017 14:37:00 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Wanpeng Li <kernellwp@...il.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Radim Krčmář <rkrcmar@...hat.com>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH v8 4/4] KVM: X86: Add flush_on_enter before guest enter

On 13/12/2017 14:35, Peter Zijlstra wrote:
>> +	if (xchg(&vcpu->arch.st.steal.preempted, KVM_VCPU_NOT_PREEMPTED) ==
>> +			(KVM_VCPU_SHOULD_FLUSH | KVM_VCPU_PREEMPTED)) {
>> +		/*
>> +		 * Do TLB_FLUSH before entering the guest, its passed
>> +		 * the stage of request checking
>> +		 */
>> +		kvm_vcpu_flush_tlb(vcpu, false);
>> +	}
> And not a single word, _anywhere_ on why this doesn't need
> invalidate_gpa or wtf that actually is.

FWIW I've fixed the changelogs in kvm/queue.

Paolo