linux-kernel - Re: [PATCH] bluecard: Fix a possible sleep-in-atomic bug in bluecard_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3DCF07A0-0080-46AD-8514-D67919A48BE2@holtmann.org>
Date:   Wed, 13 Dec 2017 14:39:42 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bluecard: Fix a possible sleep-in-atomic bug in
 bluecard_write_wakeup

Hi Jia-Ju,

> The driver may sleep in the interrupt handler.
> The function call path is:
> bluecard_interrupt (interrupt handler)
>  bluecard_write_wakeup
>    schedule_timeout --> may sleep
> 
> To fix it, schedule_timeout is replaced with mdelay.
> 
> This bug is found by my static analysis tool(DSAC) and checked by my code review.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
> drivers/bluetooth/bluecard_cs.c |    8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel