linux-kernel - Re: [PATCH v5 10/15] soundwire: Add sysfs for SoundWire DisCo properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcb3c56b-e290-7017-b797-9bcc6f1132f0@linux.intel.com>
Date:   Wed, 13 Dec 2017 08:31:35 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Vinod Koul <vinod.koul@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Mark <broonie@...nel.org>,
        Takashi <tiwai@...e.de>, patches.audio@...el.com,
        alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [PATCH v5 10/15] soundwire: Add sysfs for SoundWire DisCo
 properties



On 12/13/2017 03:54 AM, Vinod Koul wrote:
>
>>> + * Base file is:
>>> + *		properties
>>> + *		|---- interface-revision
>>> + *		|---- master-count
>>> + *		|---- link-N
>>> + *		      |---- clock-stop-modes
>>> + *		      |---- max-clock-frequency
>>> + *		      |---- clock-frequencies
>>> + *		      |---- default-frame-rows
>>> + *		      |---- default-frame-cols
>>> + *		      |---- dynamic-frame-shape
>>> + *		      |---- command-error-threshold
>>> + */
>> Why nest them so deep?  Anyway, that's not really an issue I guess, it's
>> your ABI, not mine :)
> well it gives us a hierarchical view. We have N links...
The property definitions follows the MIPI DisCo spec, there's no real 
creativity here.
That said, Vinod you need to remove the master-count - as discussed on 
the other patch where this property is read this is not relevant for a 
master if you don't have a representation of a controller.