linux-kernel - Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcNcx0C2-cPNSxABg+VB+UGrf+GfEEfVZO3tHPbmLGznA@mail.gmail.com>
Date:   Wed, 13 Dec 2017 16:54:32 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Mark Brown <broonie@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking
 is disabled

On Wed, Dec 13, 2017 at 11:28 AM, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> User space can initiate concurrent access to regmap over debugfs and,
> if the locking is disabled, we can't protect it. Don't create the
> debugfs entries at all in this case.
>
> Suggested-by: Lars-Peter Clausen <lars@...afoo.de>
> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>

> +               dev_dbg(map->dev, "locking disabled - not creating debugfs entries\n");

I dunno about level (OK debug seems good because we are still talking
about debug), though message might be slightly confusing (if driver
itself is using debugfs for its own purposes), so, I would suggest to
add
"regmap: locking...".

-- 
With Best Regards,
Andy Shevchenko