linux-kernel - Re: [PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171213143637.wl3z4twqaiwo2qdv@mwanda>
Date:   Wed, 13 Dec 2017 17:36:37 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Valentin Vidic <Valentin.Vidic@...Net.hr>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Marcin Ciupak <marcin.s.ciupak@...il.com>,
        Marcus Wolf <linux@...f-entwicklungen.de>,
        Simon Sandström <simon@...anor.nu>
Subject: Re: [PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK
 value

On Wed, Dec 13, 2017 at 03:21:53PM +0100, Valentin Vidic wrote:
> Reading from the spec, allowed values for modulation scheme
> after the shift are:
> 
>   00 FSK
>   01 OOK
>   10 - 11 reserved
> 
> Signed-off-by: Valentin Vidic <Valentin.Vidic@...Net.hr>
> ---
>  drivers/staging/pi433/rf69_registers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/pi433/rf69_registers.h b/drivers/staging/pi433/rf69_registers.h
> index 33fd91518bb0..981b57d7cc0b 100644
> --- a/drivers/staging/pi433/rf69_registers.h
> +++ b/drivers/staging/pi433/rf69_registers.h
> @@ -130,7 +130,7 @@
>  #define  DATAMODUL_MODE_CONTINUOUS_NOSYNC	0x60
>  
>  #define  DATAMODUL_MODULATION_TYPE_FSK		0x00 /* default */
> -#define  DATAMODUL_MODULATION_TYPE_OOK		0x08
> +#define  DATAMODUL_MODULATION_TYPE_OOK		0x01

Look how DATAMODUL_MODULATION_TYPE_OOK is used (in linux-next).  We
removed the shift.

regards,
dan carpenter