linux-kernel - Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header and switch to SPDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <987a243f-b7ed-6b6d-224e-2fe122d46f68@ti.com>
Date:   Wed, 13 Dec 2017 09:51:51 -0600
From:   "Andrew F. Davis" <afd@...com>
To:     Joe Perches <joe@...ches.com>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header
 and switch to SPDX

On 12/13/2017 09:50 AM, Joe Perches wrote:
> On Wed, 2017-12-13 at 09:44 -0600, Andrew F. Davis wrote:
>> On 12/12/2017 08:19 PM, Joe Perches wrote:
>>> On Tue, 2017-12-12 at 16:43 -0600, Andrew F. Davis wrote:
>>>> The filename is often wrong after moves and adds nothing of value,
>>>> lets drop it. While already here, switch to SPDX.
>>>
>>> []
>>>> diff --git a/sound/soc/codecs/tlv320aic32x4-i2c.c b/sound/soc/codecs/tlv320aic32x4-i2c.c
>>>
>>> []
>>>> @@ -1,21 +1,10 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>>  /*
>>>> - * linux/sound/soc/codecs/tlv320aic32x4-i2c.c
>>>> - *
>>>>   * Copyright 2011 NW Digital Radio
>>>>   *
>>>>   * Author: Jeremy McDermond <nh6z@...z.net>
>>>>   *
>>>>   * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27.
>>>> - *
>>>> - * This program is free software; you can redistribute it and/or modify
>>>> - * it under the terms of the GNU General Public License as published by
>>>> - * the Free Software Foundation; either version 2 of the License, or
>>>> - * (at your option) any later version.
>>>> - *
>>>> - * This program is distributed in the hope that it will be useful,
>>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>> - * GNU General Public License for more details.
>>>
>>> nack.  Note the "(at your option) any later version"
>>>
>>> If you are going to update to spdx and remove the old license
>>> verbiage, make sure you are adding the correct spdx tag.
>>>
>>
>> My bad, will fix.
>>
>> By the way, do you like these spdx update patch? Or would you rather I
>> drop this one and wait to let some script do it for the whole subsystem?
> 
> I would not touch any license text until an automated tool
> can properly do a pass over the entire kernel source tree.
> 

Just sent a message agreeing right as I got this one :)

> All the bsd variants probably require that the original text
> be left in place too.
> 

That's going to be pretty :/