linux-kernel - Re: [PATCH 0/3] kconfig: Make 'm' safe before modules symbol is defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAS9DNWkjo5PpqoMW1b_iJtMFrp+7Kp4Ycu05Po=idUS_w@mail.gmail.com>
Date:   Fri, 15 Dec 2017 08:27:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     "Yann E. MORIN" <yann.morin.1998@...e.fr>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Sam Ravnborg <sam@...nborg.org>, zippel@...ux-m68k.org,
        Nicolas Pitre <nicolas.pitre@...aro.org>,
        Michal Marek <mmarek@...e.com>, dirk@...ders.net,
        Arnaud Lacombe <lacombar@...il.com>,
        Jan Beulich <JBeulich@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] kconfig: Make 'm' safe before modules symbol is defined

2017-10-05 21:01 GMT+09:00 Ulf Magnusson <ulfalizer@...il.com>:
> Hello,
>
> This patchset fixes a segfault that occurs if 'm' appears in certain
> expressions before the modules symbol is defined. The problem is that m is
> rewritten to m && <modules symbol> already during parsing. Doing it in
> menu_finalize(), which runs after parsing, fixes the problem.
>
> To aid the review and people trying to understand menu_finalize() in the future
> (including me), it also renames menu_check_dep() to rewrite_m() and adds
> comments to clarify the existing expression rewriting and dependency
> propagation logic.
>
> The changes have been tested for regressions using zconfdump(), Kconfiglib, and
> Valgrind.
>
> Cheers,
> Ulf
>
> Ulf Magnusson (3):
>   kconfig: Rename menu_check_dep() to rewrite_m()
>   kconfig: Clarify expression rewriting
>   kconfig: Clean up modules handling and fix crash
>
>  scripts/kconfig/menu.c | 74 ++++++++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 66 insertions(+), 8 deletions(-)
>


Series, applied to linux-kbuild/kconfig.  Thanks!

-- 
Best Regards
Masahiro Yamada