linux-kernel - Re: [PATCH v3] Staging: pi433: fix brace coding style issues in pi433

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171214072911.GE27027@kroah.com>
Date:   Thu, 14 Dec 2017 08:29:11 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tomas Marek <marek_tomas@...trum.cz>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Staging: pi433: fix brace coding style issues in
 pi433_if.c

On Wed, Dec 13, 2017 at 11:31:15AM -0800, Tomas Marek wrote:
> On 12/13/2017 03:55 AM, Greg KH wrote:
> 
> > On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
> >> This patch fix several brace on next line, braces not necessary, space
> >> around =/<, and space before/after open/close parenthesis coding style
> >> errors find by checkpatch in pi433_if.c.
> >>
> >> Signed-off-by: Tomas Marek <marek_tomas@...trum.cz>
> >> ---
> >> Changes in v3:
> >>   - DIO0_irq_handler update reverted - will be submitted in separate
> >>     patch for the sake of clarity.
> >> Changes in v2:
> >>   - DIO0_irq_handler updated - 'if/else if' replaced by 'switch' and
> >>     'dev_dbg_ratelimited' used instead of 'dev_dbg' according to Joe
> >>     Perches suggestion.
> >>   - The removal of braces around SET_CHECKED() reverted - caused syntax
> >>     error and is addressed by another patch
> >>     "[PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro".
> > This doesn't apply to my tree at all :(
> >
> > Please rebase it against the staging-next branch of staging.git (or the
> > staging-testing branch to be sure), and then resend.
> >
> > thanks,
> >
> > greg k-h
> I am sorry for complications. I did it against linux-next. I'll rebase it
> against stating and cross-check against staging-testing, hopefully it will
> be fine then.

Normally linux-next is fine to do your work against.  But as you can see
on the mailing list, there are a lot of people sending a lot of patches
for this one driver.  So things end up changing quickly, usually the
merge issue is that I took a patch that was sent a few hours before
yours, and you did it all right.

Sorry, rebasing and resending patches are just a normal mode for working
on a high-traffic area in the kernel, thanks for your patience.

greg k-h