linux-kernel - Re: d1fc031747 ("sched/wait: assert the wait_queue_head lock is .."): EIP: __wake_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 17:03:00 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     kernel test robot <fengguang.wu@...el.com>
Cc:     Christoph Hellwig <hch@....de>, LKP <lkp@...org>,
        linux-kernel@...r.kernel.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        wfg@...ux.intel.com, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: d1fc031747
 ("sched/wait: assert the wait_queue_head lock is .."):  EIP:
 __wake_up_common

On Thu, 14 Dec 2017 08:50:15 +0800 kernel test robot <fengguang.wu@...el.com> wrote:

> 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> 
> commit d1fc0317472217762fa7741260ca464077b4c877
> Author:     Christoph Hellwig <hch@....de>
> AuthorDate: Wed Dec 13 11:52:12 2017 +1100
> Commit:     Stephen Rothwell <sfr@...b.auug.org.au>
> CommitDate: Wed Dec 13 16:04:58 2017 +1100
> 
>     sched/wait: assert the wait_queue_head lock is held in __wake_up_common
>     
>     Better ensure we actually hold the lock using lockdep than just commenting
>     on it.  Due to the various exported _locked interfaces it is far too easy
>     to get the locking wrong.

I'm probably sitting on an older version.  I've dropped

epoll: use the waitqueue lock to protect ep->wq
sched/wait: assert the wait_queue_head lock is held in __wake_up_common