linux-kernel - Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b46ecfe-8b6c-e169-bff6-e7ce01693a8c@redhat.com>
Date:   Thu, 14 Dec 2017 13:05:49 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        James Ettle <james@...le.org.uk>
Cc:     linux-integrity@...r.kernel.org, azhar.shaikh@...el.com,
        linux-kernel@...r.kernel.org, james.l.morris@...cle.com
Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on
 Braswell system

Hello Jarkko,

On 12/14/2017 12:21 PM, Jarkko Sakkinen wrote:
> On Mon, Dec 11, 2017 at 07:37:29PM +0000, James Ettle wrote:
>> Hello,
>>
>> [First: Apologies if cross-posting from Kernel.org BZ is bad form; my
>> distro BZ advised I post this to your mailing list as well.]
>>
>> Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU
>> breaks PS/2 keyboard and mouse. They just don't respond until after a
>> suspend/resume cycle, and after that they later stop after a while.
>>
>> I have confirmed this by blacklisting tpm modules. I noticed this
>> first with kernel 4.13, and have bisected it down to:
> 
> In my GIT tree there is now:
> 
> commit db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 (HEAD -> next, origin/next, origin/master, master)
> Author: Azhar Shaikh <azhar.shaikh@...el.com>
> Date:   Wed Dec 6 17:38:10 2017 -0800
> 
>     tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()
>     
>     Commit 5e572cab92f0bb5 ("tpm: Enable CLKRUN protocol for Braswell
>     systems") disabled CLKRUN protocol during TPM transactions and re-enabled
>     once the transaction is completed. But there were still some corner cases
>     observed where, reading of TPM header failed for savestate command
>     while going to suspend, which resulted in suspend failure.
>     To fix this issue keep the CLKRUN protocol disabled for the entire
>     duration of a single TPM command and not disabling and re-enabling
>     again for every TPM transaction. For the other TPM accesses outside
>     TPM command flow, add a higher level of disabling and re-enabling
>     the CLKRUN protocol, instead of doing for every TPM transaction.
>     
>     Fixes: 5e572cab92f0bb5 ("tpm: Enable CLKRUN protocol for Braswell systems")
>     
>     Signed-off-by: Azhar Shaikh <azhar.shaikh@...el.com>
>     Reviewed-by: Jarkko Sakkinen  <jarkko.sakkinen@...ux.intel.com>
>     Tested-by: Jarkko Sakkinen  <jarkko.sakkinen@...ux.intel.com>
>     Signed-off-by: Jarkko Sakkinen  <jarkko.sakkinen@...ux.intel.com>
> 
> Can you try this?
>

I already suggested the same [0], but James said that made no difference [1].
 
> /Jarkko
>

[0]: https://lkml.org/lkml/2017/12/12/268
[1]: https://lkml.org/lkml/2017/12/12/1127

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat