linux-kernel - Re: [PATCH] watchdog: document watchdog_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58961686-e995-8b0d-3e35-877e2da73290@roeck-us.net>
Date:   Thu, 14 Dec 2017 06:30:17 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, wim@...ana.be
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: document watchdog_init_timeout() wdd parameter

On 12/13/2017 11:41 AM, Corentin Labbe wrote:
> All parameters of watchdog_init_timeout() are documented with exception
> of wdd, thus generating a build warning.
> 
> This patch document it and so remove the following build warning:
> drivers/watchdog/watchdog_core.c:113: warning: No description found for parameter 'wdd'
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/watchdog_core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
> index 8a8d952f8df9..eb8fa25f8eb2 100644
> --- a/drivers/watchdog/watchdog_core.c
> +++ b/drivers/watchdog/watchdog_core.c
> @@ -97,6 +97,7 @@ static void watchdog_check_min_max_timeout(struct watchdog_device *wdd)
>   
>   /**
>    * watchdog_init_timeout() - initialize the timeout field
> + * @wdd: watchdog device
>    * @timeout_parm: timeout module parameter
>    * @dev: Device that stores the timeout-sec property
>    *
>