linux-kernel - Re: [PATCH] PCI/DPC: Fix shared interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 07:54:44 -0700
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Keith Busch <keith.busch@...el.com>
Cc:     linux-pci@...r.kernel.org, bhelgaas@...gle.com,
        liudongdong3@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/DPC: Fix shared interrupt handling

On Thu, 14 Dec 2017 07:50:31 -0700
Keith Busch <keith.busch@...el.com> wrote:

> On Wed, Dec 13, 2017 at 05:01:58PM -0700, Alex Williamson wrote:
> > @@ -109,6 +109,7 @@ static void interrupt_event_handler(struct work_struct *work)
> >  	struct dpc_dev *dpc = container_of(work, struct dpc_dev, work);
> >  	struct pci_dev *dev, *temp, *pdev = dpc->dev->port;
> >  	struct pci_bus *parent = pdev->subordinate;
> > +	u16 ctl;
> >  
> >  	pci_lock_rescan_remove();
> >  	list_for_each_entry_safe_reverse(dev, temp, &parent->devices,
> > @@ -135,6 +136,10 @@ static void interrupt_event_handler(struct work_struct *work)
> >  
> >  	pci_write_config_word(pdev, dpc->cap_pos + PCI_EXP_DPC_STATUS,
> >  		PCI_EXP_DPC_STATUS_TRIGGER | PCI_EXP_DPC_STATUS_INTERRUPT);
> > +
> > +	pci_read_config_word(pdev, dpc->cap_pos + PCI_EXP_DPC_CTL, &ctl);
> > +	pci_write_config_word(pdev, dpc->cap_pos + PCI_EXP_DPC_CTL,
> > +			      ctl & ~PCI_EXP_DPC_CTL_INT_EN);  
> 
> Did you mean to re-enable the interrupt here rather than mask it off?

D'oh, yes.  v2 coming.  Thanks,

Alex