linux-kernel - Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171214153139.GG9788@sirena.org.uk>
Date:   Thu, 14 Dec 2017 15:31:39 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     "Chen.Liu" <chen.liu.opensource@...il.com>, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com, shengjiu.wang@...escale.com,
        patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, daniel.baluta@....com
Subject: Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support

On Thu, Dec 14, 2017 at 11:56:48AM +0000, Charles Keepax wrote:
> On Wed, Dec 13, 2017 at 08:37:30PM +0800, Chen.Liu wrote:

> > +	if (unsupported)
> > +		snd_soc_update_bits(codec, WM8960_CLOCK1, 0x6,
> > +				WM8960_SYSCLK_DIV_2);
> > +

> Looking at this a bit more I do have some reservations. Firstly
> this divider can be set through wm8960_set_dai_clkdiv, and
> secondly it is also set at the bottom of

Removing set_clkdiv() would be a better thing if there were conflicts
here, in general we're trying to avoid uses of it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)