linux-kernel - Re: [PATCH] xtensa: dts: Remove leading 0x and 0s from bindings notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 09:03:51 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chris Zankel <chris@...kel.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xtensa: dts: Remove leading 0x and 0s from bindings notation

Hi Mathieu,

On Thu, Dec 14, 2017 at 8:54 AM, Mathieu Malaterre <malat@...ian.org> wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@...iumnetworks.com>
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  arch/xtensa/boot/dts/csp.dts                |  2 +-
>  arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi | 10 +++++-----
>  arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi  | 10 +++++-----
>  arch/xtensa/boot/dts/xtfpga-flash-4m.dtsi   |  6 +++---
>  arch/xtensa/boot/dts/xtfpga.dtsi            | 10 +++++-----
>  5 files changed, 19 insertions(+), 19 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max