linux-kernel - Re: [PATCH] platform/x86: dell-smo8800: Possible unnecessary 'out of memory' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 20:02:45 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Dhaval Shah <dhaval.shah@...tnautics.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-smo8800: Possible unnecessary 'out of
 memory' message

On Wed, Dec 13, 2017 at 10:30 AM, Pali Rohár <pali.rohar@...il.com> wrote:
> On Wednesday 13 December 2017 13:53:54 Dhaval Shah wrote:
>> Removed Possible unnecessary 'out of memory' message checkpatch warnings.
>> Issue found by checkpatch.

>> -             dev_err(&device->dev, "failed to allocate device data\n");
>
> Hi! Any particular reason for removing error message?

If you look into drivers/base/dd.c (real_probe() function IIRC) it
issues a warning when probe fails with error code.
So, basically all error messages in ->probe() are redundant (except
maybe those that prints more than error message itself).

-- 
With Best Regards,
Andy Shevchenko