linux-kernel - Re: [PATCH] pinctrl: axp209: add missing Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0aa972ed-dc37-4d03-7e08-95cc32f7a45e@infradead.org>
Date:   Thu, 14 Dec 2017 10:22:38 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>,
        linus.walleij@...aro.org
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...e-electrons.com, linux-sunxi@...glegroups.com
Subject: Re: [PATCH] pinctrl: axp209: add missing Kconfig dependencies

On 12/14/2017 01:43 AM, Quentin Schulz wrote:
> This fixes some compilation issues.
> 
> GENERIC_PINCONF and OF at least for pinconf_generic_dt_*, PINMUX at
> least for pinmux_ops and GPIOLIB for at least gpio_chip.
> 
> Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features")
> 
> Reported-by: Randy Dunlab <rdunlap@...radead.org>
> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/pinctrl/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index ce126955212c..1dd445116432 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -66,6 +66,10 @@ config PINCTRL_AS3722
>  config PINCTRL_AXP209
>  	tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support"
>  	depends on MFD_AXP20X
> +	depends on OF
> +	select PINMUX
> +	select GENERIC_PINCONF
> +	select GPIOLIB
>  	help
>  	  AXP PMICs provides multiple GPIOs that can be muxed for different
>  	  functions. This driver bundles a pinctrl driver to select the function
> 


-- 
~Randy