lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171214192626.GC3919388@devbig577.frc2.facebook.com> Date: Thu, 14 Dec 2017 11:26:26 -0800 From: "tj@...nel.org" <tj@...nel.org> To: Bart Van Assche <Bart.VanAssche@....com> Cc: "axboe@...nel.dk" <axboe@...nel.dk>, "kernel-team@...com" <kernel-team@...com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "peterz@...radead.org" <peterz@...radead.org>, "osandov@...com" <osandov@...com>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, "oleg@...hat.com" <oleg@...hat.com>, "hch@....de" <hch@....de> Subject: Re: [PATCH 4/6] blk-mq: make blk_abort_request() trigger timeout path Hello, On Thu, Dec 14, 2017 at 06:56:55PM +0000, Bart Van Assche wrote: > On Tue, 2017-12-12 at 11:01 -0800, Tejun Heo wrote: > > void blk_abort_request(struct request *req) > > { > > - if (blk_mark_rq_complete(req)) > > - return; > > > > if (req->q->mq_ops) { > > - blk_mq_rq_timed_out(req, false); > > + req->deadline = jiffies; > > + mod_timer(&req->q->timeout, 0); > > } else { > > + if (blk_mark_rq_complete(req)) > > + return; > > blk_delete_timer(req); > > blk_rq_timed_out(req); > > } > > This patch makes blk_abort_request() asynchronous for blk-mq. Have all callers > been audited to verify whether this change is safe? I *think* so. For all the ata related parts, I know they're. mtip32xx and dasd_ioctl, it seems safe, but I can't tell for sure. Will cc the respective maintainers on the next posting. Thanks. -- tejun
Powered by blists - more mailing lists