linux-kernel - Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171214202726.GA32443@kroah.com>
Date:   Thu, 14 Dec 2017 21:27:26 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Ghannam, Yazen" <Yazen.Ghannam@....com>
Cc:     Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Borislav Petkov <bp@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...capital.net>,
        Andy Lutomirski <luto@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Borislav Petkov <bp@...en8.de>,
        Brian Gerst <brgerst@...il.com>,
        Dave Jones <davej@...emonkey.org.uk>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        Thomas Gleixner <tglx@...utronix.de>,
        Toshi Kani <toshi.kani@...com>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Alex Thorlton <athorlton@....com>
Subject: Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures

On Tue, Dec 12, 2017 at 05:24:32PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Greg Kroah-Hartman [mailto:gregkh@...uxfoundation.org]
> > Sent: Sunday, December 10, 2017 4:27 PM
> > To: Ben Hutchings <ben.hutchings@...ethink.co.uk>; Ghannam, Yazen
> > <Yazen.Ghannam@....com>
> > Cc: linux-kernel@...r.kernel.org; stable@...r.kernel.org; Matt Fleming
> > <matt@...eblueprint.co.uk>; Borislav Petkov <bp@...e.de>; Andrew
> > Morton <akpm@...ux-foundation.org>; Andy Lutomirski
> > <luto@...capital.net>; Andy Lutomirski <luto@...nel.org>; Ard Biesheuvel
> > <ard.biesheuvel@...aro.org>; Borislav Petkov <bp@...en8.de>; Brian Gerst
> > <brgerst@...il.com>; Dave Jones <davej@...emonkey.org.uk>; Denys
> > Vlasenko <dvlasenk@...hat.com>; H. Peter Anvin <hpa@...or.com>; Linus
> > Torvalds <torvalds@...ux-foundation.org>; Peter Zijlstra
> > <peterz@...radead.org>; Sai Praneeth Prakhya
> > <sai.praneeth.prakhya@...el.com>; Stephen Smalley <sds@...ho.nsa.gov>;
> > Thomas Gleixner <tglx@...utronix.de>; Toshi Kani <toshi.kani@...com>;
> > linux-efi@...r.kernel.org; Ingo Molnar <mingo@...nel.org>; Ghannam,
> > Yazen <Yazen.Ghannam@....com>; Alex Thorlton <athorlton@....com>
> > Subject: Re: [PATCH 4.4 05/27] x86/efi: Build our own page table structures
> > 
> > On Thu, Dec 07, 2017 at 10:43:49PM +0000, Ben Hutchings wrote:
> > > On Mon, 2017-12-04 at 16:59 +0100, Greg Kroah-Hartman wrote:
> > > > 4.4-stable review patch.  If anyone has any objections, please let me
> > know.
> > > >
> > > > ------------------
> > > >
> > > > From: Matt Fleming <matt@...eblueprint.co.uk>
> > > >
> > > > commit 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36 upstream.
> > > [...]
> > >
> > > It looks like this will cause regressions unless you also apply:
> > >
> > > 21cdb6b56843 x86/mm: Page align the '_end' symbol to avoid pfn
> > conversion bugs
> > > b61a76f8850d x86/efi: Map RAM into the identity page table for mixed
> > mode
> > > 753b11ef8e92 x86/efi: Setup separate EFI page tables in kexec paths
> > >
> > > and possibly also:
> > >
> > > 08914f436bdd x86/platform/UV: Bring back the call to map_low_mmrs in
> > uv_system_init
> > > 683ad8092cd2 x86/efi: Fix 7-parameter efi_call()s
> > > 80e75596079f efi: Convert efi_call_virt() to efi_call_virt_pointer()
> > > d1be84a232e3 x86/uv: Update uv_bios_call() to use efi_call_virt_pointer()
> > 
> > Ugh, that's a mess.  Yazen is the one who reported this patch, and 2
> > others, were needed to resolve an issue on their hardware.
> > 
> > Yazen, any thoughts here?  Should I just revert the 3 patches, or do you
> > also feel I need all 7 of these to ensure everything works properly?
> > 
> 
> I think it's okay to revert the 3 patches.

Ugh, messy.  Ok, all now reverted.

Thanks Ben for the review, much appreciated.

greg k-h