linux-kernel - Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKdAkRTUEJqDk6Dp13Y5i1fU_ojAT8e7_DWVSqDh7uahYPHo+Q@mail.gmail.com>
Date:   Thu, 14 Dec 2017 13:44:49 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Casey Leedom <leedom@...lsio.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>,
        Komali Katari <komali@...lsio.com>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered
 over netlink

On Thu, Dec 14, 2017 at 1:38 PM, Casey Leedom <leedom@...lsio.com> wrote:
> | From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> | Sent: Thursday, December 14, 2017 12:32 PM
> |
> | As far as I can see Eric's patch is landed in 4.15-rc1 so I do not
> | think we need this patch in .14.
>
>   Except that Komali's bisect showed that the bug occured with kernel.org:
> 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 which went in on July 19, 2017 which looks like it may even have made it into 4.13 ...

No, it is not in 4.13, but it is in 4.14:

dtor@...r-ws:~/kernel/linus $ git describe --contains
1455cf8dbfd06aa7651dcfccbadb7a093944ca65
v4.14-rc1~147^2~16^2~6

This commit was causing issues because of unfortunate udev rules that
tried to load modules on any uevent except "remove" (we've fixed it to
only act on "add" now). We also added workaround for it:

dtor@...r-ws:~/kernel/linus $ git describe --contains
6878e7de6af726de47f9f3bec649c3f49e786586
v4.14-rc4~36^2~4

Unfortunately that workaround got broken with Eric's refactoring that
went into 4.15 and is being fixed with this patch.

Hope this helps.

-- 
Dmitry