linux-kernel - Re: [PATCH] fix typo in assignment of fs default overflow gid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y3m5c55b.fsf@xmission.com>
Date:   Thu, 14 Dec 2017 16:32:16 -0600
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Wolffhardt Schwabe <wolffhardt.schwabe@....de>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        viro@...IV.linux.org.uk, ptikhomirov@...tuozzo.com,
        sds@...ho.nsa.gov, Dave.Martin@....com, fweisbec@...il.com,
        ktkhai@...tuozzo.com, mhocko@...e.com, linux-kernel@...cs.fau.de,
        Anatoliy Cherepantsev <anatoliy.cherepantsev@....de>
Subject: Re: [PATCH] fix typo in assignment of fs default overflow gid

Wolffhardt Schwabe <wolffhardt.schwabe@....de> writes:

> fix typo in assignment of fs default overflow gid
>
> The patch remains without practical effect since
> both macros carry identical values.
> Still, it might become a problem in the future
> if (for whatever reason) the default overflow uid
> and gid differ.
> The DEFAULT_FS_OVERFLOWGID macro was previously unused.
>
> Signed-off-by: Wolffhardt Schwabe <wolffhardt.schwabe@....de>
> Signed-off-by: Anatoliy Cherepantsev <anatoliy.cherepantsev@....de>

Applied.  Thank you.

Eric

> ---
>  kernel/sys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 83ffd7d..f2289de 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -135,7 +135,7 @@ EXPORT_SYMBOL(overflowgid);
>   */
>  
>  int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
> -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> +int fs_overflowgid = DEFAULT_FS_OVERFLOWGID;
>  
>  EXPORT_SYMBOL(fs_overflowuid);
>  EXPORT_SYMBOL(fs_overflowgid);