lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 Dec 2017 16:43:10 -0600
From:   Steven Eckhoff <steven.eckhoff.opensource@...il.com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo
 Semiconductor's TSCS42xx audio CODEC

On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote:
> On Thu, Dec 14, 2017 at 09:32:44AM +0000, Charles Keepax wrote:
> 
> > Not sure what you mean here but setting up CODEC registers
> > directly from the machine driver is probably not ideal. You
> > should probably be looking into regmap_register_patch this lets
> > you apply a bunch of register settings to the chip every time you
> > do a regmap_cache_sync. This is useful for situations like the
> > chip has terrible register defaults you want to correct.
> 
> Thanks I will keep that in mind. For now our defaults are okay, but
> this may come in handy in other drivers. I have removed this bit from
> the next version since this can be set by the machine driver and it
> makes more sense there since the settings were configuring how the I2S
> interfaces were connected.

I apologize I had to reread that.

The settings were setting whether the bclk and lrclk would be shared
between the DAC and ADC interfaces. I thought this would make sense in
the machine driver since it knows how the devices are connected. Is
there a better way to do this?

Powered by blists - more mailing lists