linux-kernel - Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1007c70-caa4-8ca9-3d52-532e4302cc6e@gmail.com>
Date:   Fri, 15 Dec 2017 13:23:37 -0500
From:   "Austin S. Hemmelgarn" <ahferroin7@...il.com>
To:     Vincent Legoll <vincent.legoll@...il.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

On 2017-12-15 12:24, Vincent Legoll wrote:
> Hello,
> 
>>> This looks fine to me. Ard?
>>
>> Doesn't this break existing configs?
> 
> Would adding a "default yes" on the new menuconfig be OK.
> 
> If yes, I'd respin it for a v2
> 
Alternatively, would it not make some degree of sense to just turn the 
CONFIG_EFI symbol into the menuconfig?  It already controls all the EFI 
related stuff except GPT support (which should not be dependent on EFI 
support), so anyone who wants EFI support already has it enabled, and it 
would be a bit nicer to work with when actually configuring a kernel (It 
is rather annoying to have to effectively enable something twice).

The same (in theory) goes for pretty much any other patch like this 
where there's already a config option controlling it all that just isn't 
a menuconfig.