lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Dec 2017 21:51:21 +0100 From: Michal Suchánek <msuchanek@...e.de> To: Hari Bathini <hbathini@...ux.vnet.ibm.com> Cc: linuxppc-dev <linuxppc-dev@...abs.org>, Andrew Morton <akpm@...ux-foundation.org>, lkml <linux-kernel@...r.kernel.org>, Michael Ellerman <mpe@...erman.id.au>, Ankit Kumar <ankit@...ux.vnet.ibm.com>, Mahesh J Salgaonkar <mahesh@...ux.vnet.ibm.com> Subject: Re: [PATCH v9 1/8] lib/cmdline.c: remove quotes symmetrically On Wed, 15 Nov 2017 20:46:56 +0530 Hari Bathini <hbathini@...ux.vnet.ibm.com> wrote: > From: Michal Suchanek <msuchanek@...e.de> > > Remove quotes from argument value only if there is qoute on both > sides. > > Signed-off-by: Michal Suchanek <msuchanek@...e.de> > --- > lib/cmdline.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/lib/cmdline.c b/lib/cmdline.c > index 171c19b..6d398a8 100644 > --- a/lib/cmdline.c > +++ b/lib/cmdline.c > @@ -227,14 +227,12 @@ char *next_arg(char *args, char **param, char > **val) *val = args + equals + 1; > > /* Don't include quotes in value. */ > - if (**val == '"') { > - (*val)++; > - if (args[i-1] == '"') > - args[i-1] = '\0'; > + if ((args[i-1] == '"') && ((quoted) || (**val == > '"'))) { > + args[i-1] = '\0'; > + if (!quoted) > + (*val)++; > } > } > - if (quoted && args[i-1] == '"') > - args[i-1] = '\0'; > > if (args[i]) { > args[i] = '\0'; > This was only useful as separate patch with the incremental fadump update. Since the fadump update is squashed in this refresh series this can be squashed with the following lib/cmdline patch as well. Thanks Michal
Powered by blists - more mailing lists