linux-kernel - Re: [PATCH v3] dmaengine: fsl-edma: disable clks on all error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171215042319.GB18649@localhost>
Date:   Fri, 15 Dec 2017 09:53:20 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Andreas Platschek <andreas.platschek@...ntech.at>
Cc:     dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, sil2review@...ts.osadl.org
Subject: Re: [PATCH v3] dmaengine: fsl-edma: disable clks on all error paths

On Thu, Dec 14, 2017 at 12:50:51PM +0100, Andreas Platschek wrote:
> Previously enabled clks are only disabled if clk_prepare_enable() fails.
> However, there are other error paths were the previously enabled
> clocks are not disabled.
> 
> To fix the problem, fsl_disable_clocks() now takes the number of clocks
> that shall be disabled + unprepared. For existing calls were all clocks
> were already successfully prepared + enabled, DMAMUX_NR is passed to
> disable + unprepare all clocks.
> 
> In error paths were only some clocks were successfully prepared +
> enabled the loop counter is passed, in order to disable + unprepare
> all successfully prepared + enabled clocks.

Applied, thanks

-- 
~Vinod