linux-kernel - Re: [PATCH net-next v5 1/4] phylib: Add device reset delay support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171215221752.42sz53izxeebkfuq@rob-hp-laptop>
Date:   Fri, 15 Dec 2017 16:17:52 -0600
From:   Rob Herring <robh@...nel.org>
To:     Richard Leitner <dev@...l1n.net>
Cc:     mark.rutland@....com, fugang.duan@....com, andrew@...n.ch,
        f.fainelli@...il.com, frowand.list@...il.com, davem@...emloft.net,
        geert+renesas@...der.be, sergei.shtylyov@...entembedded.com,
        baruch@...s.co.il, david.wu@...k-chips.com, lukma@...x.de,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, richard.leitner@...data.com
Subject: Re: [PATCH net-next v5 1/4] phylib: Add device reset delay support

On Mon, Dec 11, 2017 at 01:16:57PM +0100, Richard Leitner wrote:
> From: Richard Leitner <richard.leitner@...data.com>
> 
> Some PHYs need a minimum time after the reset gpio was asserted and/or
> deasserted. To ensure we meet these timing requirements add two new
> optional devicetree parameters for the phy: reset-delay-us and
> reset-post-delay-us.
> 
> Signed-off-by: Richard Leitner <richard.leitner@...data.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  Documentation/devicetree/bindings/net/phy.txt | 10 ++++++++++
>  drivers/net/phy/mdio_device.c                 | 13 +++++++++++--
>  drivers/of/of_mdio.c                          |  4 ++++
>  include/linux/mdio.h                          |  2 ++
>  4 files changed, 27 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt
> index c05479f5ac7c..72860ce7f610 100644
> --- a/Documentation/devicetree/bindings/net/phy.txt
> +++ b/Documentation/devicetree/bindings/net/phy.txt
> @@ -55,6 +55,12 @@ Optional Properties:
>  
>  - reset-gpios: The GPIO phandle and specifier for the PHY reset signal.
>  
> +- reset-delay-us: Delay after the reset was asserted in microseconds.
> +  If this property is missing the delay will be skipped.
> +
> +- reset-post-delay-us: Delay after the reset was deasserted in microseconds.
> +  If this property is missing the delay will be skipped.

I think these names could be clearer as to exactly what they mean. 
Looking at existing properties with "reset-delay" there's a mixture of 
definitions whether it is the assert time or the time after deassert.

So I'd call these "reset-assert-us" and "reset-deassert-us".

Rob