linux-kernel - Re: [PATCH -mm -V2] mm, swap: Fix race between swapoff and some swap operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171215142752.8680ebf607aeae94c32760b5@linux-foundation.org>
Date:   Fri, 15 Dec 2017 14:27:52 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     "Huang, Ying" <ying.huang@...el.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>,
        Minchan Kim <minchan@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Shaohua Li <shli@...com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Jérôme Glisse <jglisse@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        David Rientjes <rientjes@...gle.com>,
        Rik van Riel <riel@...hat.com>, Jan Kara <jack@...e.cz>,
        Dave Jiang <dave.jiang@...el.com>,
        Aaron Lu <aaron.lu@...el.com>
Subject: Re: [PATCH -mm -V2] mm, swap: Fix race between swapoff and some
 swap operations

On Fri, 15 Dec 2017 11:04:43 +0100 Michal Hocko <mhocko@...nel.org> wrote:

> On Thu 14-12-17 12:42:46, Andrew Morton wrote:
> > On Thu, 14 Dec 2017 16:17:18 +0100 Michal Hocko <mhocko@...nel.org> wrote:
> > 
> > > > as fast as possible, SRCU instead of reference count is used to
> > > > implement get/put_swap_device().  From get_swap_device() to
> > > > put_swap_device(), the reader side of SRCU is locked, so
> > > > synchronize_srcu() in swapoff() will wait until put_swap_device() is
> > > > called.
> > > 
> > > It is quite unfortunate to pull SRCU as a dependency to the core kernel.
> > > Different attempts to do this have failed in the past. This one is
> > > slightly different though because I would suspect that those tiny
> > > systems do not configure swap. But who knows, maybe they do.
> > > 
> > > Anyway, if you are worried about performance then I would expect some
> > > numbers to back that worry. So why don't simply start with simpler
> > > ref count based and then optimize it later based on some actual numbers.
> > > Btw. have you considered pcp refcount framework. I would suspect that
> > > this would give you close to SRCU performance.
> > 
> > <squeaky-wheel>Or use stop_kernel() ;)</squeaky-wheel>
> 
> well, stop_kernel is a _huge_ hammer.

But it's very simple and requires zero code changes on the fast path. 
This makes it appropriate for swapoff!

> I think we can do much better
> without a large complexity. A simple ref counting (or pcp refcounting if
> the former has measurable complexity) should do just fine.

I'd like to be able to compare the implementations ;)