linux-kernel - Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are resolved.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BM1PR0101MB14443B072F71BF4CB1F85100E60B0@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>
Date:   Fri, 15 Dec 2017 05:15:15 +0000
From:   Dhaval Shah <dhaval.shah@...tnautics.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are
 resolved.

Hi Andy Shevchenko,

Thanks for the review.
________________________________________
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Thursday, December 14, 2017 11:29 PM
> To: Dhaval Shah
> Cc: Matthew Garrett; Pali Rohár; Andy Shevchenko; Platform Driver; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 0/3] platform/x86: dell-laptop: All the warnings are resolved.
> 
> On Wed, Dec 13, 2017 at 10:13 AM, Dhaval Shah
> <dhaval.shah@...tnautics.com> wrote:
> > There are total three types of warnings are resolved.
> > First patch  : Block comments use * on subsequent lines
> > Second patch : Missing a blank line after declarations
> > third patch  : braces {} are not necessary for single statement blocks.
> >
> 
> Can we survive without this? Does it break build or alike?
> 
Yes. We can survive without this. It will not break build or alike. This changes will not affects the functionality of the code.
But, it overall improves the code readability.
> 
> > Dhaval Shah (3):
> >   platform/x86: dell-laptop: Block comments use * on subsequent lines
> >   platform/x86: dell-laptop: Missing a blank line after declarations
> >   platform/x86: dell-laptop: braces {} are not necessary for single
> >     statement blocks
> >
> >  drivers/platform/x86/dell-laptop.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > --
> > 2.11.0
> >



--
With Best Regards,
Andy Shevchenko