linux-kernel - Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Dec 2017 05:17:48 +0000
From:   Dhaval Shah <dhaval.shah@...tnautics.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Pali Rohár <pali.rohar@...il.com>,
        Mario Limonciello <mario.limonciello@...l.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on
 subsequent lines

Hi Andy Shevchenko,

________________________________________
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Thursday, December 14, 2017 11:29 PM
> To: Dhaval Shah
> Cc: Pali Rohár; Mario Limonciello; dvhart@...radead.org; Andy Shevchenko; Platform Driver; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] platform/x86: dell-smbios: Block comments use * on subsequent lines
> 
> On Wed, Dec 13, 2017 at 10:21 AM, Dhaval Shah
> <dhaval.shah@...tnautics.com> wrote:
> > Resolved Block comments use * on subsequent lines checkpatch warnings.
> > Issue found by checkpatch.
> >
> 
> Same comments as for the other like this
> 

This changes will not affect the functionality but improves the code readability.

> > Signed-off-by: Dhaval Shah <dhaval.shah@...tnautics.com>
> > ---
> >  drivers/platform/x86/dell-smbios.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
> > index 6a60db515bda..25a296c90e08 100644
> > --- a/drivers/platform/x86/dell-smbios.c
> > +++ b/drivers/platform/x86/dell-smbios.c
> > @@ -353,7 +353,8 @@ static void __init parse_da_table(const struct dmi_header *dm)
> >                 container_of(dm, struct calling_interface_structure, header);
> >
> >         /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
> > -          6 bytes of entry */
> > +        * 6 bytes of entry
> > +        */
> >
> >         if (dm->length < 17)
> >                 return;
> > --
> > 2.11.0
> >



--
With Best Regards,
Andy Shevchenko